Added scan name to calls returning CompletedScan #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschneider-r7
approved these changes
Jul 31, 2017
|
thanks @bglass-r7 does this need to go out as a part of a specific release? |
|
@sgreen-r7 No specific release. Can sneak it in there if need be. Was just asked how to get the scan name from the API and didn't see it. Plus looked like a very easy update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an attribute to the CompletedScan class to return scan_name. Updated the parse methods for dyntable and json to pull out the scan name found in the results.
Motivation and Context
With the recent change in Nexpose to assign scan names and sub site schedules, having the ability to filter and lookup scans based on names could prove beneficial.
How Has This Been Tested?
I cloned the current master branch, updated the scan.rb file, built a new gem and ran a test script. The change was rather small to add the attribute to a file.
Screenshots (if appropriate):
N/A
Types of changes
Checklist: